Fix false positive confusing-naming error on generics with pointer type receiver #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisvmedia
reviewed
May 8, 2024
rule/confusing-naming.go
Outdated
Comment on lines
139
to
144
| if p, _ := t.(*ast.StarExpr); p != nil { | ||
| t = p.X | ||
| } | ||
|
|
||
| if p, _ := t.(*ast.IndexExpr); p != nil { | ||
| t = p.X |
There was a problem hiding this comment.
Preserving the original switch would be more idiomatic and let us avoiding type assertions multiple times.
There was a problem hiding this comment.
I tried to avoid a lot of code nesting. Returned the switch
Entuazism
force-pushed
the
bugfix/issue-982
branch
from
f77fa8b
to
6a2eb55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix logic to handle expressions that include pointers to generic types.
Add test data
Closes #982