Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping Python 2 drops pypy3 from github workflows #29

Closed
mgedmin opened this issue Sep 27, 2021 · 1 comment
Closed

Dropping Python 2 drops pypy3 from github workflows #29

mgedmin opened this issue Sep 27, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@mgedmin
Copy link
Owner

mgedmin commented Sep 27, 2021

Steps to reproduce:

  1. git clone https://github.com/mgedmin/irclog2html
  2. git checkout 52c154033586a31961a172efc315218e8bff7cd4
  3. check-python-versions --drop 2.7

What happens:

--- ./.github/workflows/build.yml	(original)
+++ ./.github/workflows/build.yml	(updated)
@@ -20,13 +20,10 @@
     strategy:
       matrix:
         python-version:
-          - "2.7"
           - "3.6"
           - "3.7"
           - "3.8"
           - "3.9"
-          - "pypy2"
-          - "pypy3"
 
     steps:
       - name: Git clone

What should happen: basically the same, except pypy3 should remain in place.

@mgedmin mgedmin added the bug Something isn't working label Sep 27, 2021
@mgedmin
Copy link
Owner Author

mgedmin commented Sep 27, 2021

This bug affected all workflow files using strategy.matrix.python-version, but didn't affect workflows using ZopeFoundation-style strategy.matrix.config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant