Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#12 Add sort by monotonicity #13

Merged
merged 4 commits into from Nov 13, 2020
Merged

#12 Add sort by monotonicity #13

merged 4 commits into from Nov 13, 2020

Conversation

wylswz
Copy link

@wylswz wylswz commented Nov 12, 2020

No description provided.

mgedmin
mgedmin requested changes Nov 12, 2020
View reviewed changes
Copy link
Owner

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sort regression needs to be fixed, the rest is less important.

Hmm, where's my Travis CI build status?

dozer/leak.py Show resolved Hide resolved
dozer/leak.py Outdated Show resolved Hide resolved
dozer/tests/test_util.py Outdated Show resolved Hide resolved
dozer/tests/test_util.py Outdated Show resolved Hide resolved
dozer/util.py Outdated Show resolved Hide resolved
dozer/util.py Show resolved Hide resolved
@mgedmin
Copy link
Owner

mgedmin commented Nov 12, 2020

Thank you for your contribution! It looks very interesting indeed.

@wylswz
Copy link
Author

wylswz commented Nov 13, 2020

conversations resolved

wylswz
wylswz commented Nov 13, 2020
View reviewed changes
dozer/media/graphs.html Outdated Show resolved Hide resolved
@wylswz wylswz changed the title #12 Add sort by monotonicity WIP: #12 Add sort by monotonicity Nov 13, 2020
@wylswz wylswz changed the title WIP: #12 Add sort by monotonicity #12 Add sort by monotonicity Nov 13, 2020
@wylswz wylswz requested a review from mgedmin November 13, 2020 04:44
mgedmin
mgedmin approved these changes Nov 13, 2020
View reviewed changes
Copy link
Owner

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mgedmin mgedmin merged commit 5b055dc into mgedmin:master Nov 13, 2020
@mgedmin
Copy link
Owner

mgedmin commented Nov 13, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgedmin mgedmin mgedmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wylswz @mgedmin