Display graph in IPython. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks awesome! |
mgedmin
approved these changes
Nov 21, 2016
| # Re-wrap it for utf-8 | ||
| import io | ||
| f = io.TextIOWrapper(f.detach(), 'utf-8') | ||
| if IS_INTERACTIVE: |
There was a problem hiding this comment.
Can you use elif here instead of nesting an if inside the else? I think it'll also make the diff smaller (no indentation changes for the write-to-file branch).
There was a problem hiding this comment.
I think this can be tested by injecting get_ipython() to __builtin__ .
|
Also: how would you like to be credited for this patch? |
|
This patch is credited to @dmitriyshashkin 's comment on #23 . |
mgedmin
approved these changes
Nov 21, 2016
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got this working according to #23 .
Screenshot:
