Split lib.rs into separate modules
#487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgeisler
force-pushed
the
modules
branch
3 times, most recently
from
bb3aa20
to
15bd827
Compare
This is an internal module, so the API remains unchanged as `textwrap::Options`.
This allows the to be sorted nicely.
The public API is kept unchanged.
This let’s `cargo doc` (and human readers) disambiguate them.
This brings the number of lines in `lib.rs` down to less than 1k. The split between unit tests for `fill` and `wrap` could be cleaned up: right now we test on either level depending on what looks better in the test.
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lib.rsfile has grown very big over the years and it's now just over 2k lines. This PR moves the functions and tests into a number of separate modules, leaving just the top-level documentation inlib.rs. The public API is unchanged and I hope this will make it easier to maintain the crate going forward.