Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version suffixes seem to be ignored #19

Closed
lnicola opened this issue Sep 26, 2017 · 1 comment
Closed

Version suffixes seem to be ignored #19

lnicola opened this issue Sep 26, 2017 · 1 comment
Labels
bug

Comments

@lnicola
Copy link

lnicola commented Sep 26, 2017 •
edited

That is, 1.0.0-rc1 seems to match 1.0.0-rc2 in html_root_url. This might be intended.
@mgeisler
Copy link
Owner

Thanks for the bug report! I can reproduce it... it should be easy to fix!

@mgeisler mgeisler added the bug label Sep 26, 2017
@mgeisler mgeisler mentioned this issue Sep 26, 2017
Merged
mgeisler added a commit that referenced this issue Sep 26, 2017
@mgeisler
version_matches_request: consider pre-release identifiers
1983fe5 
Before we completely ignored the pre-release identifiers when
comparing versions. This meant that a TOML block with

  [dependencies]
  foo = 1.0.0

was considered to match a crate version of 1.0.0-rc1. That was not
intended: per the semver specification, a pre-release version comes
before the normal version. So depending on version 1.0.0 would not
actually make it possible to install version 1.0.0-rc1.

Fixes #19.
@mgeisler mgeisler mentioned this issue Sep 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgeisler @lnicola