Normalize "\r\n" to "\n" to ensure ^ and $ match line boundaries #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
+ Coverage 93.54% 93.64% +0.09%
==========================================
Files 5 5
Lines 403 409 +6
==========================================
+ Hits 377 383 +6
Misses 26 26
Continue to review full report at Codecov.
|
The regex crate only considers "\n" a line boundary, so ^ and $ don't match "\r\n". This can be a problem if code is checked out on Windows and Git helpfully rewrites your "\n" to "\r\n". I ran into this problem when testing GitHub Actions on the textwrap repository. See rust-lang/regex#244.
mgeisler
force-pushed
the
windows-line-boundaries
branch
from
91a9a41
to
fee29b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex crate only considers "\n" a line boundary, so ^ and $ don't
match "\r\n". This can be a problem if code is checked out on Windows
and Git helpfully rewrites your "\n" to "\r\n". I ran into this
problem when testing GitHub Actions on the textwrap repository.
See rust-lang/regex#244.