Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDbAsyncEnumerable implementation for DbContext Async operations #5

Merged
merged 2 commits into from
Dec 29, 2016
Merged

IDbAsyncEnumerable implementation for DbContext Async operations #5

merged 2 commits into from
Dec 29, 2016

Conversation

lucasteles
Copy link

No description provided.

@mgibas
Copy link
Owner

mgibas commented Dec 28, 2016

Thanks a lot for a PR!
I have just couple minor issues that u can easily fix and we can merge it:

  • Move new classes into separate files
  • Name new classes without "Test" - maybe something like FakeDbAsyncQueryProvider instead of TestDbAsyncQueryProvider
  • Do not use regions and comments (that should be taken care of after moving to separate files)
  • Write some simple test that will cover your changes

I know these conventions are not described in readme - sorry for that :(

@lucasteles
Copy link
Author

Hy

Ok, i will do this changes as soon as possible.

Sorry about it

@lucasteles
Copy link
Author

Done

mgibas
mgibas approved these changes Dec 29, 2016
View reviewed changes
Copy link
Owner

@mgibas mgibas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot

@mgibas mgibas merged commit f4ce8e3 into mgibas:master Dec 29, 2016
@mgibas
Copy link
Owner

mgibas commented Dec 29, 2016 •
edited
Loading

Published: EntityFramework.Testing.FakeItEasy.1.0.16.0.nupkg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgibas mgibas mgibas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucasteles @mgibas