Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(buildStatus): use sessionSecret instead of token #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

xcarpentier
Copy link

No description provided.

@mglagola
Copy link
Owner

@xcarpentier Thanks for the PR!

Is there any harm in including all forms of auth? As in can we keep old headers around as a fallback?

FYI: A lot of this lib's functionality was deprecated because expo's command line tool (exp) has a lot of these automation utilities implemented now. See github.com/mglagola/exptool/wiki/Deprecations

@xcarpentier
Copy link
Author

xcarpentier commented Apr 20, 2018

Hi @mglagola,

I wasn't sure but I guess sessionSecret was there before last exp version, no? (I will figured out)

If not I will change the PR to integrate Authorization & Exp-Access-Token if into $home/.expo/state.json.

expo's command line tool: yes I know, my use case is that I need to keep build chain as it is but just upgrade without changing code for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants