Add test for setting an empty field's first item to null #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is why it's erroring. PHPStan has held onto the value when it was set to a string. PHPStan is not aware that the entity property is a FieldItemList which is \ArrayAccess but with magical getters that will return the first value. |
|
The "bug": NodeScopeResolver::processAssignVar thinks the that field value is a string which no longer is a super of \ArrayAccess and it forgets that it is a FieldItemList |
|
Parent issue was closed without this being merged, as it was apparently fixed already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This verifies a Drupal core bug when processing LinkItemTest
Fixes #228