-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Better Color Picker using iro.js? #50
Comments
Thanks @ceciliamay, just to check, is your primary wish here to have an HSL color picker mode? Style settings actually uses https://github.com/Simonwep/pickr which I believe supports HSL. I just need to enable it, which I can definitely do! |
Ahhh!! I see! Yes, my primary wish here is to have Style Settings support HSL! :D Thank you so much in advance!! |
@ceciliamay I've enabled HSL support in the color picker. Let me know if it works ok for you. I still might explore other color picker in the future, such as iro, as it turns out flatpickr is no longer maintained. |
Thanks for enabling this @mgmeyers !! It's working great. Sad that flatpickr is no longer maintained. Would be curious to see what color picker you'd choose in the future (color nerd here, lol). Again, thanks for this and for your other work!! Cheers~ |
I don't suppose it's possible to invoke the System color picker? iOS, for instance, has a very nice built-in one. |
Hey there @mgmeyers !! Thank you so much for building the Style Settings plugin - it has really helped theme developers offer more for their users! The only problem I have with it is that I am slightly unsatisfied with the current color picker because it lacks HSL. It gets the job done but in my opinion, when one knows how to use HSL, can tackle on picking colors better.
My suggestion: Consider replacing the current color picker (I think it is vanilla picker js if I am not mistaken?) with iro.js as the color picker. It can handle HEX, RGB, HSL/HSLA spaces.
What do you think?
The text was updated successfully, but these errors were encountered: