Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Background color #33

Open
Calorion opened this issue Mar 2, 2022 · 7 comments
Open

Feature request: Background color #33

Calorion opened this issue Mar 2, 2022 · 7 comments

Comments

@Calorion
Copy link

Calorion commented Mar 2, 2022

I would like to be able to specify a background color for the body field.

@hungsu
Copy link
Owner

hungsu commented Mar 3, 2022

Hi @Calorion ! Thankfully this is easy. Do you mind updating your version of Typomagical, and trying the setting in Typomagical Color Settings ?

@Calorion
Copy link
Author

Calorion commented Mar 3, 2022

  1. The System panes become transparent when I turn "allow background color override" on if the color is set to default.
  2. I only want the color to apply to the text body, not the System panes.
  3. Unfortunately, I think you're going to need two different options: A Light Mode and a Dark Mode color.
  4. I don't suppose you can invoke the System color picker? iOS, for instance, has a very nice built-in one.

Other than that, it works!

@hungsu
Copy link
Owner

hungsu commented Mar 3, 2022

Hi @Calorion ,

Regarding transparent system panes and colour applying to system panes, what version of Obsidian and what operating system did you see this problem on? And by chance are you using the Translucent window setting in Appearance ? I'm not observing this problem on my Windows or Mac machines, on 0.13.26

As for system color picker, that's out of my hands as it's controlled by the Style Settings Plugin. There is discussion about a better picker over here: mgmeyers/obsidian-style-settings#50

@Calorion
Copy link
Author

Calorion commented Mar 4, 2022

Regarding transparent system panes and colour applying to system panes, what version of Obsidian and what operating system did you see this problem on?

iPadOS 15.2.1, Obsidian 1.1.0.

And by chance are you using the Translucent window setting in Appearance ? I'm not observing this problem on my Windows or Mac machines, on 0.13.26

That setting has no effect.

@Smitty010
Copy link

I observed the problem on Windows (Obsidian 1.1.16). The settings dialog became unreadable as soon as I clicked on "Allow Background color override" (it was the only setting I changed in the Style Settings). I had to find the typomagical settings in the Style plugin data.json and delete the line to get my Obsidian usable again.

@hungsu
Copy link
Owner

hungsu commented Mar 28, 2023

I see the problem. Putting together a fix

hungsu added a commit that referenced this issue Mar 28, 2023
@hungsu
Copy link
Owner

hungsu commented Mar 28, 2023

This should be fixed now in Typomagical 1.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants