Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional Root AMI Encryption #6

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Optional Root AMI Encryption #6

wants to merge 1 commit into from

Conversation

icereval
Copy link
Contributor

@icereval icereval commented Jan 29, 2017 •
edited
Loading

@icereval icereval changed the title Encrypt Volumes Including Root Using Copied AMI Encrypt Volumes and Optional Root AMI Jan 29, 2017
@mgoodness
Copy link
Owner

Can we put etcd data volume encryption behind a bool, as with the AMI? It should default to true, but the option makes node-by-node upgrades easier.

@icereval
Copy link
Contributor Author

icereval commented Jan 29, 2017 •
edited
Loading

Looks like encrypted root volume's are not working with the latest stable AMI's for CoreOS, more here.

coreos/bugs#1692 (comment)

@mgoodness
Copy link
Owner

mgoodness commented Jan 30, 2017 •
edited
Loading

Want to pull the etcd EBS encryption out into its own PR, and hold off the AMI work in the hopes it's addressed upstream?

@icereval
Copy link
Contributor Author

Sure, I'll get a PR up tomorrow.

@icereval icereval mentioned this pull request Jan 31, 2017
Merged
@icereval
Copy link
Contributor Author

rebased w/ only ami encryption

@icereval icereval changed the title Encrypt Volumes and Optional Root AMI Optional Root AMI Encryption Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icereval @mgoodness