New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor constructing FrameTime #77

Open

mgoral opened this issue Dec 22, 2016 · 0 comments

Labels

Internal improvement Low Priority

Owner

mgoral commented Dec 22, 2016

It's a little messy right now, better approach would be something like this:

class FrameTime:
  def __init__(self, fps): pass # empty (0) FT

  @classmethod
  def FromFrame(cls, frame, fps): pass # from frame format

  @classmethod
  def FromSeconds(cls, secs, fps): pass # from seconds

  @classmethod
  def FromStrptime(cls, s, fps, fmt): pass # something like parsing "1:01:02", but should accept strings with subset of strptime format

mgoral added Internal improvement Low Priority labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment