Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging #11

Closed
rafidini opened this issue Jun 1, 2022 · 1 comment
Closed

Logging #11

rafidini opened this issue Jun 1, 2022 · 1 comment
Assignees
@rafidini
Labels
enhancement New feature or request

Comments

@rafidini
Copy link
Collaborator

rafidini commented Jun 1, 2022

I tested everything with various scenarios and they work well!

I am thinking of adding some sort of optional parameter to the ergo connection object to enable or disable logging. What do you think @rafidini ?

Originally posted by @mgpai22 in #4 (comment)
@rafidini rafidini added the enhancement New feature or request label Jun 1, 2022
@rafidini rafidini changed the title Feature: Logging Logging Jun 1, 2022
@rafidini rafidini assigned rafidini and unassigned mgpai22 Sep 18, 2022
rafidini added a commit that referenced this issue Sep 18, 2022
@rafidini
feat: utility for logs (#11)
b5fd9b8 
✨ Add a logs package : format the logging and set the logging level to info (for now)
✅ Add a test for the logs feature

fix #11
@rafidini
Copy link
Collaborator Author

Hello @mgpai22, let us go back on track 🚀

I committed some changes to the logs issue (#11), for now, it is very simple and I only added it to a new example (example_7_*.py) to make sure the feature works properly.

But I have an issue running the example, this is my output:

Screenshot 2022-09-18 at 13 22 40

I'll create a new issue to separate it from this feature 🔧

@rafidini rafidini mentioned this issue Sep 18, 2022
Closed
rafidini added a commit that referenced this issue Sep 18, 2022
@rafidini
fix: examples (#21)
f5c7b1b 
🩹 fix the issue about connecting to testnet

fix #21
link #11
@rafidini rafidini mentioned this issue Sep 18, 2022
Closed
rafidini added a commit that referenced this issue Sep 18, 2022
@rafidini
fix(tests): integration (#22)
9627d9a 
🐛 Changed returned value structure

link #11
fix #22
@rafidini rafidini mentioned this issue Sep 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafidini rafidini

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

issue/11/logging mgpai22/ergpy
2 participants
@mgpai22 @rafidini