Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command-line interface #20

Open
rafidini opened this issue Jun 6, 2022 · 4 comments
Open

Command-line interface #20

rafidini opened this issue Jun 6, 2022 · 4 comments
Assignees
@mgpai22 @rafidini
Labels
enhancement New feature or request

Comments

@rafidini
Copy link
Collaborator

rafidini commented Jun 6, 2022

Is your feature request related to a problem? Please describe.
In order to make it easy to interact with the package, a CLI might be needed.

Describe the solution you'd like
Call CLI like the following examples :

  • ergpy send simple <addr1> <addr2>
  • ergpy send token <id> <addr1> <addr2>
  • ergpy get wallet-addresses --no-addresses 2
  • ergpy get box-info <index> <addr>

Warning
@mgpai22 I will need your help defining the commands' behavior.

Additional context

  • argparse — Parser for command-line options, arguments and sub-commands
@rafidini rafidini self-assigned this Jun 6, 2022
@rafidini rafidini added the enhancement New feature or request label Jun 6, 2022
@rafidini rafidini changed the title ergpy command-line interface (CLI) Command-line interface Jun 6, 2022
@rafidini
Copy link
Collaborator Author

Back on it

rafidini added a commit that referenced this issue Jan 20, 2023
@rafidini
feat(cli): add get_wallet_address and get_box_info (#20)
2626ed4 
✨ add CLI feature
🎨 add local import
🔖 upgrade to `0.1.10.0`
📌 add `click` dependencies

ref(issue): #20
@rafidini rafidini mentioned this issue Jan 21, 2023
Open
9 tasks
rafidini added a commit that referenced this issue Jan 21, 2023
@rafidini
feat(cli): add version + minor change (#20)
c3ff6e1 
✨ add `version` subcommand
🔨 make options required
🔖 add the `__version__` variable to keep track of version

link #20 #26
rafidini added a commit that referenced this issue Jan 21, 2023
@rafidini
docs(README): redesign (#20)
e58ba6a
rafidini added a commit that referenced this issue Jan 21, 2023
@rafidini
docs(README): add CI badge (#20)
481a41a
rafidini added a commit that referenced this issue Jan 21, 2023
@rafidini
docs(README): correct title (#20)
96772c7
@mgpai22
Copy link
Owner

mgpai22 commented Jan 21, 2023

Hey thanks for getting back on this!

I have skimmed through this it looks good so far. I have not worked on programming a CLI so I guess I will be learning along.

Once you get further along the documentation I will play around with it and make modifications as necessary.

Currently a suggestion I have is to store a persistent mnemonic during the first use of CLI. This could perhaps be encrypted.

@rafidini
Copy link
Collaborator Author

rafidini commented Jan 21, 2023 •
edited
Loading

Hey thanks for getting back on this!

I have skimmed through this it looks good so far. I have not worked on programming a CLI so I guess I will be learning along.

Once you get further along the documentation I will play around with it and make modifications as necessary.

Currently a suggestion I have is to store a persistent mnemonic during the first use of CLI. This could perhaps be encrypted.

I will look at how we can do that local store, good idea indeed !

In addition to that GitHub will soon release a Roadmap feature on Projects, so if you want you can create a Project to track the features that have to be implemented.

@mgpai22
Copy link
Owner

mgpai22 commented Jan 21, 2023

Roadmap sounds interesting!

rafidini added a commit that referenced this issue Jan 21, 2023
@rafidini
feat(cli): add ergpy send simple subcommand (#20)
8df035e 
✨ `send simple` subcommand

link #20 #26
rafidini added a commit that referenced this issue Jan 21, 2023
@rafidini
feat(cli): add ergpy send token subcommand (#20)
046ad98 
✨ `send token` subcommand

link #20 #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgpai22 mgpai22

@rafidini rafidini

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

issue/20/cli mgpai22/ergpy
2 participants
@mgpai22 @rafidini