Simplify TI Monad #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the state only actually uses the supply and I do not see any reason why it should be an environment reader (although one could probably refactor the actual type inference function accordingly). Since this code might be the best step-by-step implementation of algorithm W, let us not complicate matters with unnecessary haskellisms. Signed-off-by: Christoph Höger <christoph.hoeger@celeraone.com>
|
Thanks for the PR and the kind words. I don't recall why I made it that complicated in the first place... BTW, hope you are doing well, Christoph :) |
|
Indeed I do. I am even getting paid to implement said algorithm in a functional language :D. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the state only actually uses the supply and I do not see any
reason why it should be an environment reader (although one could
probably refactor the actual type inference function
accordingly). Since this code might be the best step-by-step
implementation of algorithm W, let us not complicate matters with
unnecessary haskellisms.
Signed-off-by: Christoph Höger christoph.hoeger@celeraone.com