Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the generation of type variable names #8

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

rcythr
Copy link
Contributor

@rcythr rcythr commented May 26, 2020

Great resource, thanks for putting it out on the web for everyone to learn from.

I thought the type and output of newTyVar was a little ugly, so I wrote up a little patch to change it:

  1. It no longer requires an argument, which is quite satisfying looking in the Monad.
  2. It produces more friendly TyVar values.

This is mostly an aesthetic thing as I much prefer type variables (a, b, c, d, ..., aa, ab, ...) to (a0, a1, a2, a3, a4, ...). If you don't agree then feel free to reject this PR.

…s (i.e. a, b, c, etc) instead of a0, a1, a2, etc.
@mgrabmueller mgrabmueller merged commit 928700e into mgrabmueller:master Jun 3, 2020
@mgrabmueller
Copy link
Owner

Thanks for the contribution, I like the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants