Fix NativeAOT warnings #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check IsDynamicCodeSupported in Delegates.GetGetter before trying to create a DynamicMethod - Check IsDynamicCodeSupported in PerTypeHelpers before trying to MakeGenericType, which can fail for value types in NativeAOT. Fix mgravell#72
eerhardt
commented
Apr 28, 2023
| #if NETCOREAPP3_0_OR_GREATER | ||
| && RuntimeFeature.IsDynamicCodeSupported | ||
| #endif | ||
| ) | ||
| { | ||
| try | ||
| { |
There was a problem hiding this comment.
TBH: I'm not sure what the code in the try is doing.
- Why isn't it returning the result of the Reflection?
- If we just want to return
UnmanagedAllocator<T>.Shared, why not justreturn UnmanagedAllocator<T>.Shared;?
I was half of the mind to just delete this code, since it doesn't appear to work, and doesn't appear to have any unit tests that test ArenaFlags.PreferUnmanaged and ArenaFlags.PreferPinned. But the current proposal won't change any behavior on normal CoreCLR and it gets rid of the warning on Native AOT.
mgravell
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #72
cc @mgravell