Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazily populate the FS. The current implementation passes tests but has hefty technical debt.
fs.rs
intoeager.rs
. 24d9704Nodelike
parsing/unparsing logic to simplify loading foreager::FS
, too. 9268a77resolve_node
to fixpoint. aba72bcIt's tempting to have eager mode work with the lazy FS by just forcing resolution during startup. There would be some overhead, though. How much? We can do benchmarking on three modes: lazy, lazy with
--force-early
, and the existing eager. dd152f1 shows that lazy with--force-early
is on par with eager. So once we can have lazy outputting in whatever format, we can drop eager entirely.