[BUGFIX] Prevents memory leaks on static object ($my)

Release resources once the main object goes out of scope.
mgreter · Mar 10, 2014 · 4f8fd2a · 4f8fd2a
1 parent c77cda1
commit 4f8fd2a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/lib/pQuery.pm b/lib/pQuery.pm
@@ -37,11 +37,6 @@ sub PQUERY {
     return 'PQUERY'->new(@_);
 }
 
-sub reset{
-    $my = {};
-    undef $document;
-}
-
 #------------------------------------------------------------------------------#
 # New ideas / Playing around stuffs
 #------------------------------------------------------------------------------#
@@ -879,6 +874,8 @@ sub _find_elems {
     }
 }
 
+sub DESTROY { delete $my->{$_[0]}; }
+
 #------------------------------------------------------------------------------#
 # THE AMAZING PQUERY
 #------------------------------------------------------------------------------#
@@ -1158,10 +1155,6 @@ This method returns the index number of its argument if the elem is in the
 current pQuery object. Otherwise it returns -1.
 
 
-=head2 reset()
-
-This method releases resources associated with pQuery and prevents memory leaks
-
 =head1 UNDER CONSTRUCTION
 
 This module is still being written. The documented methods all work as

diff --git a/t/reset.t b/t/reset.t
@@ -13,7 +13,6 @@ no_leaks_ok{
 	my $i = shift;
 	my $elem = $_;
 			  });
-    $pq->reset();
 } 'memory leak with traversal';