Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension breaks the new task view #213

Closed
brettmiller opened this issue Jun 13, 2022 · 5 comments
Closed

extension breaks the new task view #213

brettmiller opened this issue Jun 13, 2022 · 5 comments

Comments

@brettmiller
Copy link

Todoist introduced a "new task view" in Web version 2083. With the todoist-shortcuts extension enable the new task view doesn't work and is the old style. With the extension disabled the new task view works as expected.

@mgsloan
Copy link
Owner

mgsloan commented Jun 17, 2022

Hey, what version of todoist-shortcuts are you on? This has been discussed on #204

I did just notice that the scheduling keybinding was broken, but that is now fixed in version 151

@brettmiller
Copy link
Author

I'm on 152. The extension works, but it ends up with the old task view instead of the new view.

This is what I see after hitting Enter with a task selected

Without the extension enabled:
todoist_task_without_shortcuts_extension

With the extension enabled:
todoist_with_shortcuts_extension

@mgsloan
Copy link
Owner

mgsloan commented Jun 17, 2022 via email

@brettmiller
Copy link
Author

Ah, that makes sense. I've been using this extension pretty much since I started using Todoist, but I've always just used 'Enter' to modify a selected task and when Todoist announced changes to the selected task view and I wasn't seeing them I turned off the extension to see if that was why and it was. I can try to modify my habits to use 'i' if I want see the new task view.

I have noticed something that does seem to be an actual bug. If you hit 'enter' to edit a task and then 'esc' to close it, the focus is taken away from the task, but the task isn't properly closed (as it would be if clicking the 'cancel' button). You also can't select the task again after it looses focus unless you either tap it's 'cancel' button or select another task with 'enter' (then that task goes into the same weird state). After hitting 'esc' and the task loosing focus it seems to put focus on the previous last in the list, but the highlight to the left of the task to show it as selected isn't there. If this would be better in a new issue let me know and I can open one and then this one can be closed.

@mgsloan
Copy link
Owner

mgsloan commented Jun 26, 2022

If you hit 'enter' to edit a task and then 'esc' to close it, the focus is taken away from the task, but the task isn't properly closed

Hmm, curiously I don't see this bug! For me escape closes the task editor. Feel free to open a bug about it.

You also can't select the task again after it looses focus unless you either tap it's 'cancel' button or select another task with 'enter' (then that task goes into the same weird state). After hitting 'esc' and the task loosing focus it seems to put focus on the previous last in the list, but the highlight to the left of the task to show it as selected isn't there.

Ah, good catch! Fixed this in version 153.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants