Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get followLink to find links in task_content OR task_description #236

Closed
mdbraber opened this issue Jan 16, 2023 · 2 comments
Closed

Get followLink to find links in task_content OR task_description #236

mdbraber opened this issue Jan 16, 2023 · 2 comments

Comments

@mdbraber
Copy link
Contributor

I'm trying to get followLink to find a link either in the task_content (title) or task_description - but don't know what the best code would be. Any suggestions?
@mdbraber
Copy link
Contributor Author

Well - maybe it's simpler than I thought: could we change task_content in https://github.com/mgsloan/todoist-shortcuts/blob/master/src/todoist-shortcuts.js#L462 to task_list_item__content (which is the div including task_content and task_description). Would that break anything else @mgsloan ?

mgsloan added a commit that referenced this issue Jan 24, 2023
@mgsloan
Also follow links in task descriptions #236
eb637be
mgsloan added a commit that referenced this issue Jan 24, 2023
@mgsloan
Changelog update #236
4f69288
@mgsloan
Copy link
Owner

mgsloan commented Jan 24, 2023

Good idea! I didn't notice this since I never use descriptions (though maybe I should!). Included in version 173

@mgsloan mgsloan closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgsloan @mdbraber