Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate includes Filters and Labels list, if visible #262

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

adamleerich
Copy link
Contributor

Hello @mgsloan, this change adds the list of Filters and Labels back into the navigation shortcuts when that screen is visible, like it used to be long ago when Filters and Labels were in the navigation pane below projects. If F&L are not visible typing g fl will open that screen, then g again will show shortcuts next to each F&L just as it does for items in the navigation pane.

The selectors section[aria-label=Labels] and section[aria-label=Filters] are applied to the document object, but they return unique objects even as coarse as they are. Let me know if you want to refine it!

Thanks! --Adam

@adamleerich
Copy link
Contributor Author

@mgsloan please let me know if you have any questions about this!

@mgsloan mgsloan merged commit c5c7362 into mgsloan:master Dec 24, 2023
@mgsloan
Copy link
Owner

mgsloan commented Dec 24, 2023

Thank you! I've updated the position of the tips in filters&labels view and made it so that navigation mode continues when filters&labels is selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants