Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing selected task while in task view #265

Closed
flinesse opened this issue Dec 18, 2023 · 2 comments
Closed

Editing selected task while in task view #265

flinesse opened this issue Dec 18, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@flinesse
Copy link

flinesse commented Dec 18, 2023

Hi, I've been using this plugin with Todoist running as a PWA, and the experience has been much better compared to running the app natively. One thing I've felt consistent friction over however, is the lack of a keybind to edit the task while in task view. It feels awkward to not be able to edit while having the selected task front and center, needing to resort to hitting <tab> multiple times to cycle through DOM elements until I get a hover on the task description box. I feel like a keybind for this would be a sensible and practical addition—helpful when there is a need to edit without distractions, i.e. when writing notes (uncompletable tasks) or tasks with lengthier descriptions. I'd like to see this be possible, perhaps with <enter> or <i> (currently bound to taskViewClose).

I'm curious to hear your thoughts. Thanks again for this wonderful project.

Sidenote: I leverage (S)uper (D)uper Mode from jasonrudolph/keyboard to achieve a mouseless textbox editing experience on macOS, which makes this potential feature even more appealing to me. I believe glacambre/firenvim also helps achieve this, but have not tried it personally.

@mgsloan mgsloan added the enhancement New feature or request label Jan 13, 2024
@mgsloan
Copy link
Owner

mgsloan commented Jan 13, 2024

Forgot to comment here / close. Great point definitely an omission. As of version 191 a few weeks ago, enter now edits the task in task view

@mgsloan mgsloan closed this as completed Jan 13, 2024
@flinesse
Copy link
Author

flinesse commented Jan 22, 2024

@mgsloan Hi, I'm on ver 194 but have not been able to get this feature working.

Just spitballing here—looking at the associated commit, would the following element be a better candidate for simulating the click on?

<div role="button" tabindex="0" data-action-hint="task-detail-view-edit" aria-label="Task description" aria-description="Activate to edit the task description" class="task-overview-description">
...
</div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants