Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple things broken (e.g.: close pane) when task opened in v5085 #269

Closed
champagnealexandre opened this issue Jan 24, 2024 · 1 comment

Comments

@champagnealexandre
Copy link

champagnealexandre commented Jan 24, 2024

Let’s say I open a task with the i key, then a lot of things seem to break. Pressing i again to close the task pane yields:

todoist-shortcuts:"Couldn't find unique descendant matching query""button[aria-label=\"Close modal\"]"", instead got"null
"
getStack@user-script:14:5529:22
warn@user-script:14:5512:30
withUnique@user-script:14:5593:11
@user-script:14:2640:17
withUnique@user-script:14:5591:15
taskViewClose@user-script:14:2639:15
@user-script:14:6301:39
_fireCallback@user-script:14:634:25
@user-script:14:703:34
@user-script:14:1056:37
@user-script:14:763:27
@user-script:14:930:34
genericKeyHandler@user-script:14:6394:38
s@https://todoist.b-cdn.net/assets/vendor~authentication~app~add~electron-login-229eafb5.1cb8b1bfb338fce472c180ac556f6f98.js:1:71428"

Edit: sorry I’m not smart enough with CSS/jscript to provide a fix myself. I wish I could do more.

Edit # 2: looks like I got it working!

Replacing L1553 of todoist-shortcuts.js,
withUnique(taskView, 'button[aria-label="Close modal"]', click);
with
withUnique(taskView, 'button[aria-label="Close task"]', click);
fixes the issue!

Now let’s wait and see what else they’ve broken...

mgsloan added a commit that referenced this issue Mar 10, 2024
@mgsloan
Copy link
Owner

mgsloan commented Mar 10, 2024

Sorry about the delay! Fixed in version 195

@mgsloan mgsloan closed this as completed Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants