Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action bar hidden when applying actions #32

Closed
amix opened this issue Jul 6, 2018 · 3 comments
Closed

Action bar hidden when applying actions #32

amix opened this issue Jul 6, 2018 · 3 comments

Comments

@amix
Copy link

amix commented Jul 6, 2018

Steps to reproduce:

  • Select multiple tasks
  • Apply an action (e.g., 2 to change priority)

What I expect:

  • That the top action bar will stay visible

What happens:

  • Tasks are selected, but the top action bar gets hidden
@mgsloan
Copy link
Owner

mgsloan commented Jul 6, 2018

Thanks for the report! I actually had a workaround for this issue - 6938cb9#diff-abbd4e09a53fc33643ce46f145654694L791 - but I removed it since I no longer saw the issue. I didn't notice that this case still remained. My guess is that rapidly selecting multiple items, at humanly impossible speeds, confuses Todoist's top bar visibility logic.

Rather than reinstating that hack, I've disabled attempting to restore selections after priority changes. This particularly makes sense to me because priority changing actions were the only one with selection restoration - I had not yet applied it to move-to-project or reschedule. Those are trickier since there are multiple steps to the interaction.

Perhaps Todoist's behavior could be changed here? It seems useful to keep the selections after doing group actions. This would require a good way to deselect all items with the mouse, and I'm not sure what that should be. Perhaps clicking off to the sides of the editor / shift clicking there?

@amix
Copy link
Author

amix commented Jul 16, 2018

Thanks for looking into this, @mgsloan

Perhaps Todoist's behavior could be changed here?

Yea, it's something we will need to think about. This said, from the stats we have most people only do one action to some items (it's not common to do the same action to the same items).

@amix amix closed this as completed Jul 16, 2018
@mgsloan
Copy link
Owner

mgsloan commented Jul 16, 2018

That makes sense! Yeah I'm not sure if I ever need to do more than one action to some items either. We'll see - I think for now it's best to have consistent behavior and so deselecting is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants