Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Keys must be unique" error on favorited filters #79

Closed
ismig opened this issue Jul 13, 2019 · 2 comments
Closed

"Keys must be unique" error on favorited filters #79

ismig opened this issue Jul 13, 2019 · 2 comments

Comments

@ismig
Copy link

ismig commented Jul 13, 2019

I have an "Assigned to others" filters that I added to my favorites. When I press 'g', this error pops up on the console: "keys ao must be unique."

Looking at the code, "Assigned to others" is a special name that always gets assigned the key "ao". So I guess the filter and its entry in the favorites list are treated as duplicates, causing that error.

It may be innocuous but it does create some log spam. In particular, I opened the console to look into why the "tp", "tf", and "tl" keys weren't showing up anymore, but instead I got a spate of this.

@mgsloan
Copy link
Owner

mgsloan commented Jul 13, 2019

Thanks for reporting the issue and looking into it! I've uploaded version 56 which I believe should resolve it, but I admit I haven't actually tested it. Please let me know if the new version behaves well for this case.

@ismig
Copy link
Author

ismig commented Jul 21, 2019

I'm not seeing the error any more, so I'd call it good. Thanks for the fix!

@ismig ismig closed this as completed Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants