factor out PR spack#7536

mgsternberg · Mar 20, 2018 · 04c1343 · 04c1343
1 parent caa35a2
commit 04c1343
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/lib/spack/spack/environment.py b/lib/spack/spack/environment.py
@@ -454,11 +454,9 @@ def return_separator_if_any(*args):
                     search = sep.join(after_list[start:end + 1])
                 except IndexError:
                     env.prepend_path(x, after)
-                    continue
 
                 if search not in before:
                     # We just need to set the variable to the new value
-                    # TODO: resolve DUP to "except" branch just above,
                     env.prepend_path(x, after)
                 else:
                     try:
@@ -532,8 +530,8 @@ def validate(env, errstream):
 
 
 def filter_environment_blacklist(env, variables):
-    """Generator that filters out any change to environment variables present
-    in the input list.
+    """Generator that filters out any change to environment variables present in
+    the input list.
 
     Args:
         env: list of environment modifications