Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated API usages #41

Closed
mguenther opened this issue Jan 6, 2020 · 1 comment
Closed

Fix deprecated API usages #41

mguenther opened this issue Jan 6, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mguenther
Copy link
Owner

We currently have two sources of deprecated API usages that we should address as soon as possible. Violations are:

  • DefaultRecordConsumer should call poll(Duration) instead of poll(long)
  • EmbeddedConnectConfig: Remove INTERNAL_KEY_CONVERTER_CLASS_CONFIG
  • EmbeddedConnectConfig: Remove INTERNAL_VALUE_CONVERTER_CLASS_CONFIG
  • EmbeddedConnectConfigTest: Remove INTERNAL_KEY_CONVERTER_CLASS_CONFIG
  • EmbeddedConnectConfigTest: Remove INTERNAL_VALUE_CONVERTER_CLASS_CONFIG
@mguenther mguenther added this to the backlog milestone Jan 6, 2020
@mguenther
Copy link
Owner Author

Fixed the deprecation on EmbeddedConnectConfig and EmbeddedConnectConfigTest.

Won't fix for now for DefaultRecordConsumer. We rely on the metadata updates to provide seek-semantics for our adhoc consumer. Since the API documentation of kafka-clients only marks the poll(long) method as deprecated, but does not say that it is going to be removed (KIP-266 does neither), we'll keep this as it is for now. The reason is that using poll(Duration) would overly complicate the code of the adhoc consumer, since we'd have to wait until we get the first assignments and handle potentially received records as well. We'll fix this if we really have to, but for now, the probable issue of blocking on metadata updates seems fine to me in the context of integration tests.

@mguenther mguenther self-assigned this Dec 28, 2020
@mguenther mguenther added the enhancement New feature or request label Dec 28, 2020
@mguenther mguenther modified the milestones: backlog, 2.7.0 Dec 28, 2020
mguenther added a commit that referenced this issue Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant