Linux: Systemd unit improvements #247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thaodan
force-pushed
the
systemd_units_improvements
branch
7 times, most recently
from
8ae9103
to
c508af8
Compare
|
That's a lot of changes, need to investigate and learn more recent stuff around systemd |
|
Can you check again? |
Fixes: 75f2f87 Signed-off-by: Björn Bidar <bjorn.bidar@thaodan.de>
Formated as per: https://en.opensuse.org/openSUSE:Creating_a_changes_file_(RPM) Changelog will be appended as needed by the obs. Fixes: 75f2f87 Signed-off-by: Björn Bidar <bjorn.bidar@thaodan.de>
Thaodan
force-pushed
the
systemd_units_improvements
branch
19 times, most recently
from
bc119a9
to
4c29793
Compare
Thaodan
force-pushed
the
systemd_units_improvements
branch
from
4c29793
to
e089b98
Compare
Fixes E: superfluous-%clean-section: The spec section %clean should not be used any longer. RPM provides its own clean logic. Signed-off-by: Björn Bidar <bjorn.bidar@thaodan.de>
Fixes: W: name-repeated-in-summary DavMail Signed-off-by: Björn Bidar <bjorn.bidar@thaodan.de>
Signed-off-by: Björn Bidar <bjorn.bidar@thaodan.de>
This unit allows running Davmail in the systemd --user instance. Loosely based on the already existing systemd unit and Arch's systemd-user unit. Re: https://aur.archlinux.org/cgit/aur.git/tree/davmail@.user_service?h=davmail Signed-off-by: Björn Bidar <bjorn.bidar@thaodan.de>
Instead of creating the file manually each time the service is started. Signed-off-by: Björn Bidar <bjorn.bidar@thaodan.de>
Signed-off-by: Björn Bidar <bjorn.bidar@thaodan.de>
Signed-off-by: Björn Bidar <bjorn.bidar@thaodan.de>
Signed-off-by: Björn Bidar <bjorn.bidar@thaodan.de>
Signed-off-by: Björn Bidar <bjorn.bidar@thaodan.de>
Read: man 5 systemd.exec Signed-off-by: Björn Bidar <bjorn.bidar@thaodan.de>
Thaodan
force-pushed
the
systemd_units_improvements
branch
2 times, most recently
from
9bdda43
to
6e53b11
Compare
The davmail script in src/bin is used everywhere no mention of davmail-wrapper. Also the script was installed into an invalid path. Signed-off-by: Björn Bidar <bjorn.bidar@thaodan.de>
Ensures that systemd is installed before davmail so %post etc work. Solves: /var/tmp/rpm-tmp.HZLayD: line 15: /usr/bin/systemd-tmpfiles: No such file or directory Or similar. Signed-off-by: Björn Bidar <bjorn.bidar@thaodan.de>
Thaodan
force-pushed
the
systemd_units_improvements
branch
from
6e53b11
to
64491ae
Compare
|
Why does the user service use the template parameter? I will always be executed under the user who starts the service (that is what |
|
For example multiple instances of davmail per account. |
|
Fair enough 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements to the systemd units like increased security, simplicity,
user service and system service template unit.