enh: simplify nipype etelemetry ping handling #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wait, I think we don't need this much, really. |
oesteban
force-pushed
the
fix/nipype-et-patch
branch
from
6a9c8d1
to
dfb10ff
Compare
mgxd
reviewed
Jun 3, 2020
mgxd
reviewed
Jun 3, 2020
| @@ -33,6 +33,7 @@ install_requires = | |||
| psutil >= 5.4 | |||
| pybids >= 0.10.2 | |||
| pyyaml | |||
| requests | |||
There was a problem hiding this comment.
at this point, why not just add etelemetry directly and leverage the check there:
etelemetry.get_project("nipy/nipype")
There was a problem hiding this comment.
I thought of using _etrequest directly, but we really don't want to do any kind of error handling. After going through the code it seemed more lightweight
There was a problem hiding this comment.
You bring up a good point... it would be useful to have an exception-free version in etelemetry.
oesteban
force-pushed
the
fix/nipype-et-patch
branch
from
4ebe491
to
74d1920
Compare
oesteban
force-pushed
the
fix/nipype-et-patch
branch
from
74d1920
to
a8b5d03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are setting pretty up-to-date nipype version restrictions on
setup.cfg, the version check and logging it are unnecessary and confusing.But, we still want to record nipype users, so let's just ping manually.