Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system installed "puppet" binary #50

Closed
wants to merge 1 commit into from

Conversation

njam
Copy link
Contributor

@njam njam commented Jan 24, 2016

I suggest to use the puppet binary on the user/system's PATH, instead of the one installed with the puppet gem.

Both Puppetlabs and librarian-puppet recommend installing puppet with the provided installer packages, and not with rubygems:
rodjek/librarian-puppet#38
https://docs.puppetlabs.com/puppet/3.8/reference/install_gem.html

This will allow the user to use the puppet version he wants to use.

Additionally it avoids problems with mixing GEM_HOMEs between system ruby, vagrant and vagrant-librarian-puppet (only when running bundle exec vagrant in the repo?).

@mhahn wdyt?

@jhoblitt
Copy link
Member

@njam How would this work with the dependency gems that will be installed by vagrant?

@njam
Copy link
Contributor Author

njam commented Feb 16, 2016

@jhoblitt which dependency gems do you mean? Some that have binaries on the PATH?

@jhoblitt
Copy link
Member

@njam Gems which have a dependency on the puppet gem.

@njam
Copy link
Contributor Author

njam commented Apr 27, 2016

Not sure if I correctly understand what you mean :D

You mean that vagrant-librarian-puppet wouldn't be able to use the puppet command of the puppet gem anymore, that is installed as a dependency (via gemspec)?

That's correct, and I think it's better that users install puppet through the proper release channels as recommended by puppetlabs. Also librarian-puppet will tell the user to do it.

wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants