Skip to content

Commit

Permalink
Typos
Browse files Browse the repository at this point in the history
  • Loading branch information
Sajjon authored and mhammond committed May 24, 2024
1 parent 33ea536 commit d73a4c7
Show file tree
Hide file tree
Showing 155 changed files with 246 additions and 246 deletions.
24 changes: 12 additions & 12 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ Bumped the version of rusqlite/libsqlite3-sys, meaning the bundled sqlite versio

### ✨ What's New ✨

- Added an `info` command to add to the `nimbus-fml` command line ([#5967](https://github.com/mozilla/application-services/pull/5967)). It outputs JSON / YAML with a summmary of each feature including:
- Added an `info` command to add to the `nimbus-fml` command line ([#5967](https://github.com/mozilla/application-services/pull/5967)). It outputs JSON / YAML with a summary of each feature including:
- the types used, as a proxy for feature complexity
- [feature metadata](https://experimenter.info/fml/feature-metadata), including documentation and events
- the schema hash and defaults hash.
Expand Down Expand Up @@ -774,7 +774,7 @@ The Tabs engine is now more efficient in how it fetches its records:
- For example, the Notification Service in iOS creates its own instance of the account manager, changes its state (by changing the index of the last retrieved send tab)
- The main account manager held by the application should call` resetPersistedState` before calling any other method that might change its state. This way it can retrieve the most up to date index that the Notification Services persisted.
### What's changed
- The `processRawIncomingAccountEvent` function will now process all commands, not just one. This moves the responsibilty of ensuring each push gets a UI element to the caller.
- The `processRawIncomingAccountEvent` function will now process all commands, not just one. This moves the responsibility of ensuring each push gets a UI element to the caller.

# v96.0.1 (_2022-11-18_)

Expand Down Expand Up @@ -1328,7 +1328,7 @@ The Tabs engine is now more efficient in how it fetches its records:
## Places

### What's Changed
- The database initialization code now uses BEGIN IMMIDIATE to start a
- The database initialization code now uses BEGIN IMMEDIATE to start a
transaction. This will hopefully prevent `database is locked` errors when
opening a sync connection.

Expand Down Expand Up @@ -1852,7 +1852,7 @@ Note: Though this is technically a breaking change, we do not expect any consume
### ⚠️ Breaking Changes ⚠️
- The old StateV1 persisted state schema is now removed. ([#4218](https://github.com/mozilla/application-services/pull/4218))
Users on very old versions of this component will no longer be able to cleanly update to this version. Instead, the consumer code
will recieve an error indicating that the schema was not correctly formated.
will receive an error indicating that the schema was not correctly formatted.

## Nimbus
### What's Changed
Expand Down Expand Up @@ -1994,7 +1994,7 @@ Fixed an error migrating from version 1 to version 2 of the database.

### ⚠️ Breaking changes ⚠️

- Moved the `Nimbus` class and its test class from Android Components into this repository. Existing integrations should pass a delegate in to provide Nimbus with a thread to do I/O and networking on, and an Obsevrer.
- Moved the `Nimbus` class and its test class from Android Components into this repository. Existing integrations should pass a delegate in to provide Nimbus with a thread to do I/O and networking on, and an Observer.
Fixed in the complementary [android-components#10144](https://github.com/mozilla-mobile/android-components/pull/10144)


Expand Down Expand Up @@ -2029,7 +2029,7 @@ Fixed an error migrating from version 1 to version 2 of the database.

### What's changed

- Make `channel` targeting comparision case-insensitive. ([#4009](https://github.com/mozilla/application-services/pull/4009))
- Make `channel` targeting comparison case-insensitive. ([#4009](https://github.com/mozilla/application-services/pull/4009))


# v75.0.0 (_2021-03-29_)
Expand Down Expand Up @@ -2525,7 +2525,7 @@ the full megazord.

## General

- This release only exists to correct issues that occured when publishing a v61.0.11, which failed to produce an artifact because of a warning which occured during the build process. (It contains a small number of additional cherry-picked patches which correct these warnings).
- This release only exists to correct issues that occurred when publishing a v61.0.11, which failed to produce an artifact because of a warning which occurred during the build process. (It contains a small number of additional cherry-picked patches which correct these warnings).

# v61.0.11 (_2020-08-07_)

Expand Down Expand Up @@ -2643,7 +2643,7 @@ the full megazord.

- Remove the node.js integration tests helper and removes node from the circleci environment. ([#3187](https://github.com/mozilla/application-services/pull/3187))
- Put `backtrace` behind a cargo feature. ([#3213](https://github.com/mozilla/application-services/pull/3213))
- Move sqlite dependency down from rc_cryto to nss_sys. ([#3198](https://github.com/mozilla/application-services/pull/3198))
- Move sqlite dependency down from rc_crypto to nss_sys. ([#3198](https://github.com/mozilla/application-services/pull/3198))
- Adds jwe encryption in scoped_keys. ([#3195](https://github.com/mozilla/application-services/pull/3195))
- Adds an implementation for [pbkdf2](https://www.ietf.org/rfc/rfc2898.txt). ([#3193](https://github.com/mozilla/application-services/pull/3193))
- Fix bug to correctly return the given defaults when the storageArea's `get()` method is used with an empty store ([bug 1645598](https://bugzilla.mozilla.org/show_bug.cgi?id=1645598)). ([#3236](https://github.com/mozilla/application-services/pull/3236))
Expand Down Expand Up @@ -3439,7 +3439,7 @@ This release exists only to rectify a publishing error that occurred with v0.42.

### What's new

- Android: Exposed `stroage::bookmarks::erase_everything`, which deletes all bookmarks without affecting history, through FFI. ([#2012](https://github.com/mozilla/application-services/pull/2012))
- Android: Exposed `storage::bookmarks::erase_everything`, which deletes all bookmarks without affecting history, through FFI. ([#2012](https://github.com/mozilla/application-services/pull/2012))

## FxA Client

Expand Down Expand Up @@ -4550,7 +4550,7 @@ and working around subtle build issues.
- New methods on PlacesConnection (Breaking changes for classes implementing PlacesAPI):
- `fun deleteVisit(url: String, timestamp: Long)`: If a visit exists at the specified timestamp for the specified URL, delete it. This change will be synced if it is the last remaining visit (standard caveat for partial visit deletion). ([#621](https://github.com/mozilla/application-services/issues/621))
- `fun deleteVisitsBetween(start: Long, end: Long)`: Similar to `deleteVisitsSince(start)`, but takes an end date. ([#621](https://github.com/mozilla/application-services/issues/621))
- `fun getVisitInfos(start: Long, end: Long = Long.MAX_VALUE): List<VisitInfo>`: Returns a more detailed set of information about the visits that occured. ([#619](https://github.com/mozilla/application-services/issues/619))
- `fun getVisitInfos(start: Long, end: Long = Long.MAX_VALUE): List<VisitInfo>`: Returns a more detailed set of information about the visits that occurred. ([#619](https://github.com/mozilla/application-services/issues/619))
- `VisitInfo` is a new data class that contains a visit's url, title, timestamp, and type.
- `fun wipeLocal()`: Deletes all history entries without recording any sync information. ([#611](https://github.com/mozilla/application-services/issues/611)).

Expand Down Expand Up @@ -4722,7 +4722,7 @@ and working around subtle build issues.

- In most cases, opaque integer handles are now used to pass data over the FFI ([#567](https://github.com/mozilla/application-services/issues/567)). This should be more robust, and allow detection of many types of errors that would previously cause silent memory corruption.

This should be mostly transparent, but is a semi-breaking semantic change in the case that something throws an exception indicating that the Rust code paniced (which should only occur due to bugs anyway). If this occurs, all subsequent operations on that object (except `close`/`lock`) will cause errors. It is "poisoned", in Rust terminology. (In the future, this may be handled automatically)
This should be mostly transparent, but is a semi-breaking semantic change in the case that something throws an exception indicating that the Rust code panicked (which should only occur due to bugs anyway). If this occurs, all subsequent operations on that object (except `close`/`lock`) will cause errors. It is "poisoned", in Rust terminology. (In the future, this may be handled automatically)

This may seem inconvenient, but it should be an improvement over the previous version, where we instead would simply carry on despite potentially having corrupted internal state.

Expand Down Expand Up @@ -4771,7 +4771,7 @@ Some APIs which are semantically internal (but exposed for various reasons) have
### What's New

- The fxa-client android library will now write logs to logcat. ([#533](https://github.com/mozilla/application-services/pull/533))
- The fxa-client Android and iOS librairies will throw a differentiated exception for general network errors. ([#535](https://github.com/mozilla/application-services/pull/535))
- The fxa-client Android and iOS libraries will throw a differentiated exception for general network errors. ([#535](https://github.com/mozilla/application-services/pull/535))

# 0.13.1 (_2019-01-10_)

Expand Down
6 changes: 3 additions & 3 deletions DEPENDENCIES.md
Original file line number Diff line number Diff line change
Expand Up @@ -2234,7 +2234,7 @@ The following text applies to code linked from these dependencies:
* The implementation was written so as to conform with Netscapes SSL.
*
* This library is free for commercial and non-commercial use as long as
* the following conditions are aheared to. The following conditions
* the following conditions are adhered to. The following conditions
* apply to all code found in this distribution, be it the RC4, RSA,
* lhash, DES, etc., code; not just the SSL code. The SSL documentation
* included with this distribution is covered by the same copyright terms
Expand All @@ -2259,7 +2259,7 @@ The following text applies to code linked from these dependencies:
* must display the following acknowledgement:
* "This product includes cryptographic software written by
* Eric Young (eay@cryptsoft.com)"
* The word 'cryptographic' can be left out if the rouines from the library
* The word 'cryptographic' can be left out if the routines from the library
* being used are not cryptographic related :-).
* 4. If you include any Windows specific code (or a derivative thereof) from
* the apps directory (application code) you must include an acknowledgement:
Expand All @@ -2277,7 +2277,7 @@ The following text applies to code linked from these dependencies:
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
* The licence and distribution terms for any publically available version or
* The licence and distribution terms for any publicly available version or
* derivative of this code cannot be changed. i.e. this code cannot simply be
* copied and put under another distribution licence
* [including the GNU Public Licence.]
Expand Down
2 changes: 1 addition & 1 deletion automation/shared.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def check_output(*args, **kwargs):
def ensure_working_tree_clean():
"""Error out if there are un-committed or staged files in the working tree."""
if run_cmd_checked(["git", "status", "--porcelain"], capture_output=True).stdout:
fatal_err("The working tree has un-commited or staged files.")
fatal_err("The working tree has un-committed or staged files.")

def find_app_services_root():
"""Find the absolute path of the Application services repository root."""
Expand Down
2 changes: 1 addition & 1 deletion build-scripts/build-cli-app.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ set -e
#
# CircleCI then stores this as an artifact, and pushes it to Github on each release.
#
# This will be downloaded and unzipped as part of the buid processes for iOS and Android.
# This will be downloaded and unzipped as part of the build processes for iOS and Android.
TARGETS="aarch64-apple-darwin x86_64-unknown-linux-musl x86_64-apple-darwin x86_64-pc-windows-gnu"
DRY_RUN=false
DIRTY=false
Expand Down
2 changes: 1 addition & 1 deletion build-scripts/substitute-local-appservices.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// will be configured to look for development versions published to the local maven repository.
//
// There is a companion gradle command `autoPublishForLocalDevelopment` that can be used to publish
// the local development versions that are targetted by this script.
// the local development versions that are targeted by this script.

def version = null
if (gradle.hasProperty("localProperties.autoPublish.application-services.dir")) {
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ ext.libsGitSha = "git --git-dir=${rootProject.rootDir}/.git diff --name-only mai
// downloaded libs.

// XX: Since we switched the libs directory to be `darwin-x86-64` and `darwin-aarch64` in https://github.com/mozilla/application-services/pull/4792
// we have mimatch with the libs built on CI, since they have the libraries under `darwin`.
// we have mismatch with the libs built on CI, since they have the libraries under `darwin`.
// Temporarily, we are disabling downloaded libs
// we should enable them once our CI builds libs the same way as our local environments
// see: https://github.com/mozilla/application-services/issues/4828
Expand Down
2 changes: 1 addition & 1 deletion components/as-ohttp-client/src/as_ohttp_client.udl
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ interface OhttpSession {
constructor([ByRef] sequence<u8> config);

// Encapsulate an HTTP request as Binary HTTP and then encrypt that
// payload using HPKE. The caller is reponsible for sending the
// payload using HPKE. The caller is responsible for sending the
// resulting message to the Relay.
[Throws=OhttpError]
sequence<u8> encapsulate([ByRef] string method,
Expand Down
4 changes: 2 additions & 2 deletions components/autofill/src/db/addresses.rs
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ pub(crate) fn update_address(
}

/// Updates all fields including metadata - although the change counter gets
/// slighly special treatment (eg, when called by Sync we don't want the
/// slightly special treatment (eg, when called by Sync we don't want the
/// change counter incremented)
pub(crate) fn update_internal_address(
tx: &Transaction<'_>,
Expand Down Expand Up @@ -379,7 +379,7 @@ mod tests {
)
.expect("should contain saved address");

// creating a third address with a tombstone to ensure it's not retunred
// creating a third address with a tombstone to ensure it's not returned
let saved_address3 = add_address(
&db,
UpdatableAddressFields {
Expand Down
2 changes: 1 addition & 1 deletion components/autofill/src/db/credit_cards.rs
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ pub(crate) mod tests {
},
)?;

// creating a third credit card with a tombstone to ensure it's not retunred
// creating a third credit card with a tombstone to ensure it's not returned
let saved_credit_card3 = add_credit_card(
&db,
UpdatableCreditCardFields {
Expand Down
2 changes: 1 addition & 1 deletion components/autofill/src/db/store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ pub fn get_registered_sync_engine(engine_id: &SyncEngineId) -> Option<Box<dyn Sy
SyncEngineId::CreditCards => {
Some(Box::new(crate::sync::credit_card::create_engine(store)))
}
// panicing here seems reasonable - it's a static error if this
// panicking here seems reasonable - it's a static error if this
// it hit, not something that runtime conditions can influence.
_ => unreachable!("can't provide unknown engine: {}", engine_id),
},
Expand Down
4 changes: 2 additions & 2 deletions components/crashtest/src/crashtest.udl
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ namespace crashtest {

// Trigger a panic inside the Rust code.
//
// This function simulates the occurence of an unexpected state inside
// This function simulates the occurrence of an unexpected state inside
// the Rust code that causes it to panic. We build our Rust components to
// unwind on panic, so after calling this function through the foreign
// language bindings, you should expect it to intercept the panic translate
Expand All @@ -35,7 +35,7 @@ namespace crashtest {

// Trigger an error inside the Rust code.
//
// This function simulates the occurence of an expected error inside
// This function simulates the occurrence of an expected error inside
// the Rust code. You should expect calling this function to throw the
// foreign-language representation of the [`CrashTestError`] class.
//
Expand Down
4 changes: 2 additions & 2 deletions components/crashtest/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ pub fn trigger_rust_abort() {

/// Trigger a panic inside the Rust code.
///
/// This function simulates the occurence of an unexpected state inside
/// This function simulates the occurrence of an unexpected state inside
/// the Rust code that causes it to panic. We build our Rust components to
/// unwind on panic, so after calling this function through the foreign
/// language bindings, you should expect it to intercept the panic translate
Expand All @@ -48,7 +48,7 @@ pub fn trigger_rust_panic() {

/// Trigger an error inside the Rust code.
///
/// This function simulates the occurence of an expected error inside
/// This function simulates the occurrence of an expected error inside
/// the Rust code. You should expect calling this function to throw the
/// foreign-language representation of the [`CrashTestError`] class.
///
Expand Down
2 changes: 1 addition & 1 deletion components/fxa-client/android/metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# consideration
# the following known consumers of the fxaclient component Android bindings:
#
# * Fenix for Andriod
# * Fenix for Android

---
$schema: moz://mozilla.org/schemas/glean/metrics/2-0-0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ class FxaClient(inner: FirefoxAccount, persistCallback: PersistCallback?) : Auto
}

/**
* Disconnect from the account and optionaly destroy our device record.
* Disconnect from the account and optionally destroy our device record.
* `beginOAuthFlow` will need to be called to reconnect.
*
* This performs network requests, and should not be used on the main thread.
Expand Down
4 changes: 2 additions & 2 deletions components/fxa-client/ios/FxAClient/FxAccountManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ open class FxAccountManager {
var constellation: DeviceConstellation?
var latestOAuthStateParam: String?

/// Instanciate the account manager.
/// Instantiate the account manager.
/// This class is intended to be long-lived within your app.
/// `keychainAccessGroup` is especially important if you are
/// using the manager in iOS App Extensions.
Expand Down Expand Up @@ -378,7 +378,7 @@ open class FxAccountManager {
profile = nil
constellation = nil
accountStorage.clear()
// If we cannot instanciate FxA something is *really* wrong, crashing is a valid option.
// If we cannot instantiate FxA something is *really* wrong, crashing is a valid option.
account = createAccount()
DispatchQueue.main.async {
NotificationCenter.default.post(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ open class MZKeychainWrapper {
return removeObject(forKey: key, withAccessibility: accessibility, isSynchronizable: isSynchronizable)
}

/// Remove an object associated with a specified key. If re-using a key but with a different accessibility, first remove the previous key value using removeObjectForKey(:withAccessibility) using the same accessibilty it was saved with.
/// Remove an object associated with a specified key. If re-using a key but with a different accessibility, first remove the previous key value using removeObjectForKey(:withAccessibility) using the same accessibility it was saved with.
///
/// - parameter forKey: The key value to remove data for.
/// - parameter withAccessibility: Optional accessibility level to use when looking up the keychain item.
Expand All @@ -346,7 +346,7 @@ open class MZKeychainWrapper {
return status == errSecSuccess
}

/// Remove all keychain data added through KeychainWrapper. This will only delete items matching the currnt ServiceName and AccessGroup if one is set.
/// Remove all keychain data added through KeychainWrapper. This will only delete items matching the current ServiceName and AccessGroup if one is set.
@discardableResult open func removeAllKeys() -> Bool {
// Setup dictionary to access keychain and specify we are using a generic password (rather than a certificate, internet password, etc)
var keychainQueryDictionary: [String: Any] = [SecClass: kSecClassGenericPassword]
Expand Down
Loading

0 comments on commit d73a4c7

Please sign in to comment.