Don't re-export imports outside of __init__.py (#2226)

.github/workflows/main.yml

@@ -114,7 +114,7 @@ jobs:
       - run: pycln . --config=pycln.toml --check
       - uses: chartboost/ruff-action@v1
         with:
-          version: '0.3.4'
+          version: '0.3.7'
       - uses: psf/black@stable
         with:
           options: "--fast --check --diff --verbose"

.pre-commit-config.yaml

@@ -28,7 +28,7 @@ repos:
         args: [--config=pycln.toml]
         verbose: true
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.3.4
+    rev: v0.3.7
     hooks:
       - id: ruff # Run the linter.
         args: [--fix]

Pythonwin/pywin/framework/scriptutils.py

@@ -528,7 +528,7 @@ def CheckFile():
 
 
 def RunTabNanny(filename):
-    import io as io
+    import io
 
     tabnanny = FindTabNanny()
     if tabnanny is None:

adodbapi/process_connect_string.py

@@ -1,6 +1,6 @@
 """ a clumsy attempt at a macro language to let the programmer execute code on the server (ex: determine 64bit)"""
 
-from . import is64bit as is64bit
+from . import is64bit
 
 
 def macro_call(macro_name, args, kwargs):

com/win32com/client/gencache.py

@@ -60,7 +60,7 @@
 # Typing as Any because PyITypeLib is not exposed
 demandGeneratedTypeLibraries: dict[tuple[str, int, int, int], Any] = {}
 
-import pickle as pickle
+import pickle
 
 
 def __init__():
@@ -91,7 +91,7 @@ def _SaveDicts():
 def _LoadDicts():
     # Load the dictionary from a .zip file if that is where we live.
     if is_zip:
-        import io as io
+        import io
 
         loader = win32com.__loader__
         arc_path = loader.archive

ruff.toml

@@ -1,18 +1,26 @@
+# Target the oldest supported version
 target-version = "py37"
 
 [lint]
-select = ["I"]
+select = [
+  "I",   # isort
+  "PLC", # Pylint Convention
+]
+
+[lint.per-file-ignores]
+# Explicit re-exports is fine in __init__.py, still a code smell elsewhere.
+"__init__.py" = ["PLC0414"]
 
 [lint.isort]
 combine-as-imports = true
 # Because pywin32 has a mix of relative and absolute imports, with undetectable first-party c-extensions
 # This makes import grouping more consistent
 detect-same-package = false
 known-third-party = [
-    "__main__",
-    # This forces distutils imports to always be after setuptools
-    # setuptools must be imported before distutils because it monkey-patches it.
-    # distutils is also removed in Python 3.12 and deprecated with setuptools
-    "distutils",
+  "__main__",
+  # This forces distutils imports to always be after setuptools
+  # setuptools must be imported before distutils because it monkey-patches it.
+  # distutils is also removed in Python 3.12 and deprecated with setuptools
+  "distutils",
 ]
 extra-standard-library = ["setuptools"]

win32/winxpgui.py

@@ -7,7 +7,9 @@
 
 import warnings
 
-from win32console import GetConsoleWindow as GetConsoleWindow
+from win32console import (
+    GetConsoleWindow as GetConsoleWindow,  # noqa: PLC0414 # Explicit re-export
+)
 from win32gui import *
 
 warnings.warn(