_fixup_sdk_dirs in setup.py will become redundant

[zooba]

Just as an FYI, I submitted the patch for distutils/setuptools that will make this hack in your setup.py redundant:

pywin32/setup.py

Line 530 in e1c0237

def _fixup_sdk_dirs(self):

The PR is at pypa/distutils#153 (and should go into setuptools after that) for reference.

I haven't tried, but I believe the code in your setup.py will still work, and none of the asserts will trigger. So you may not notice anything at all (unless you happen to see that there are twice as many include/lib directories in the compiler commands). There's no good way to detect that it's running with a fixed setuptools, so I guess just be aware that if the asserts do start triggering, it may be intentional and they can be relaxed a bit.

[mhammond]

Thanks for the heads-up Steve!

[mhammond]

pywin32's build will now fail unless setuptools is fairly recent, so once that lands, I'll just force a requirement on that new version. I'm sure you can imagine how much I want to kill some of the crazy stuff setup.py does :)

[kxrob]

#1936 includes removal of the _fixup_sdk_dirs() mechanism.

[Avasam]

@mhammond @zooba Should this have been closed by #1936 ?