Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Python 3.8 #1430

Closed
wants to merge 2 commits into from
Closed

Support for Python 3.8 #1430

wants to merge 2 commits into from

Conversation

CristiFati
Copy link
Contributor

@CristiFati CristiFati commented Oct 18, 2019

Importing any of the modules fails:

[cfati@CFATI-5510-0:C:\WINDOWS\system32]> "e:\Work\Dev\VEnvs\py_064_03.08.00_test0\Scripts\python.exe" -c "import win32api"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: DLL load failed while importing win32api: The specified module could not be found.

Details are in [GitHub]: mhammond/pywin32 - python 3.8.

Note: I consider this a quick and dirty fix, considering [Python.Bugs]: Deprecate and remove pth files.

Tested by manually replacing the .pth file on Python 3.8.0, 3.7.3, 3.6.8 and 2.7.15 VEnvs, and following the above procedure.

@CristiFati
Copy link
Contributor Author

Could someone (higher ranked) take a look?
All tests failed, but according to failures, None because of my changes (or I might be missing something).

@CristiFati
Copy link
Contributor Author

@mhammond: Sorry if I'm being too pushy, but it seems to be a problem with the tests, and for a while I didn't see any activity on the repo. Would it be possible for you to take a look (or delegate)?

@CristiFati CristiFati mentioned this pull request Nov 1, 2019
@mhammond
Copy link
Owner

mhammond commented Nov 5, 2019

Thanks - I ended up doing the same thing via 71afa71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants