Remove support for Python 2.x #1510
Conversation
|
This will surely make things easier, but I was expecting one last bug fix release before dropping 2.7 altogether. The adodbapi code, especially the documentation, could use some cleanup before release. I had to keep some ugly things in place for backwards compatibility reasons, and I can get rid of those now. How much time to I have to make things pretty? |
|
I can still make a release before landing this - what significant bugs since 227 make this worthwhile? Re making things pretty, I'm not sure if you mean "how long between killing py2 and the next release"? If so, I'm fairly flexible :) Feel free to push relevant changes to this branch if you want, then all such cleanups could land at the same time. |
|
My day job is really getting in the way here. I finally found time to spin
up a new Windows VM to check for sure what I thought I remembered.
The current version does not have the fix to make "install adodbapi" work.
Let's publish that fix before writing 2.7 off as an obsolete thing. (And
what a fine day that will be.)
…On Sat, May 2, 2020 at 10:39 PM Mark Hammond ***@***.***> wrote:
I can still make a release before landing this - what significant bugs
since 227 make this worthwhile?
Re making things pretty, I'm not sure if you mean "how long between
killing py2 and the next release"? If so, I'm fairly flexible :) Feel free
to push relevant changes to this branch if you want, then all such cleanups
could land at the same time.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1510 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEZOBME7XTSQRRHS2PGKUTRPTYOZANCNFSM4MXR22BQ>
.
|
|
@vernondcole I've updated this branch and split some of the commits - the ones which change adodbapi are now in their own commits to make it easier for you to review. It would be great if you can have a look. I'm hoping to merge this within the next week or so, but don't currently have plans to make a release - so there will still be some time after merging this to update other things, such as docs etc. Let me know what you think. |
mhammond
force-pushed
the
kill-py2
branch
2 times, most recently
from
5f2687a
to
eda5f4f
Compare
Done via 2to3 with fixers: -f basestring -f exec -f except -f dict -f import -f imports -f next -f nonzero -f print -f raise -f raw_input -f long -f standarderror -f types -f unicode -f urllib -f xrange
Done via 2to3 with fixers: -f basestring -f exec -f except -f dict -f import -f imports -f next -f nonzero -f raise -f raw_input -f long -f standarderror -f types -f unicode -f urllib -f xrange -f future
mhammond
force-pushed
the
kill-py2
branch
3 times, most recently
from
20af532
to
22b7b6f
Compare
|
the |
Also add some error constants to the module.
…ime objects on 3.6+ Because datetime on 3.6+ will not let us create them with year or month being zero.
I'm going to remove Python 2.x support, which will make things alot simpler. There are still lots of places that do, eg,
sys.version_info < (3,)and I might get to some of these or I might not - it doesn't really matter if they hang around a bit longer.