Avoid COM dates that end up with ms=1000, instead rounding to the nex… #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
doh - 1.0 is a day - I'll push up a fix |
|
I downloaded the wheel file from this branch. The ValueError Exception is no longer thrown and times appear correct to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t second. Fixes #1655.
Thanks for the repro @hujiaxing! However, instead of truncating the ms to 999.0 I instead rounded up to the next second. Does that look correct to you? Note also that you should be able to get builds from this PR to test if you are keen by following the links to the CI (ie, test) runs and looking for the "artifacts".