Fix: win32print.SetJob sending ANSI to UNICODE API #1849
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1281.
Confirmed when investigating [SO]: How to change username of job in print queue using python & win32print.
Modified the script in the bug. The scenario is even easier to reproduce: simply pass the dictionary returned by GetJob to SetJob, and the error pops up (actually there are different errors depending on level (1, 2) - as also encountered in the SO URL).
The cause is straightforward: JOB_INFO_* structures have LPTSTR (wchar_t* when built with -DUNICODE -D_UNICODE) members, while PyArg_ParseTupleAndKeywords, fills char* s for z format specifiers. Check [Python.Docs]: Parsing arguments and building values.
The fix is to specify the Unicode format specifier (Z).
After rebuilding the .pyd (and placing it in the site-packages dir), the error no longer pops up, and changing existing jobs string properties is possible (tried setting pUserName to random strings and the change is reflected in the print queue).
Environment: Python 3.9.9 (pc064) with PyWin32 303.