Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve _d handling #2169

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Improve _d handling #2169

merged 3 commits into from
Jan 29, 2024

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Jan 27, 2024

Checks that the filename w/o extension ends with _d rather than checking for _d anywhere in the file path. Closes #1949
Standardized the ternary assignement of "_d"
Fix and simplifies a test.

@mhammond mhammond merged commit 452c094 into mhammond:main Jan 29, 2024
16 checks passed
@Avasam Avasam deleted the improve-_d-handling branch January 29, 2024 14:40
@Avasam Avasam mentioned this pull request Mar 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhammond mhammond mhammond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pywin32_postinstall.py does not work if path contains _d
2 participants
@Avasam @mhammond