Improving unit tests assertion messages #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
unittest-asserts
branch
2 times, most recently
from
2dbdaf7
to
4895c7a
Compare
mhammond
approved these changes
Jun 4, 2024
clin1234
pushed a commit
to clin1234/pywin32
that referenced
this pull request
Jun 7, 2024
Using `unittest` assertion methods where possible (since this project doesn't use pytest) Raise `NotImplementedError` for unimplemented methods Use `raise AssertionError` instead of `assert 0` (except in `pywin/debugger`, in case that's done on purpose)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
unittestassertion methods where possible (since this project doesn't use pytest)Raise
NotImplementedErrorfor unimplemented methodsUse
raise AssertionErrorinstead ofassert 0(except inpywin/debugger, in case that's done on purpose)