Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace spans for items #1

Open
mhansen opened this issue Oct 8, 2021 · 4 comments · May be fixed by #22
Open

Add trace spans for items #1

mhansen opened this issue Oct 8, 2021 · 4 comments · May be fixed by #22

Comments

@mhansen
Copy link
Owner

mhansen commented Oct 8, 2021

with_items commonly adds latency, we should profile each item. We might need an extra callback from the callback library to achieve this though, or we could just fudge it and say when the next task or item starts, the last item has finished.

@louisquentinjoucla
Copy link
Contributor

louisquentinjoucla commented Jun 16, 2022

Hey 👋

With callback v2_runner_item_on_ok, v2_runner_item_on_failed, we have result in params which contains start date, duration, end date etc..., looks promising, so no need to fudge, here is an example with some echo on a loop:

image

@mhansen
Copy link
Owner Author

mhansen commented Jun 16, 2022

Oh, neat! I didn't know the params had start date/duration. I was assuming above that we'd need another callback when an item starts, but we won't need that if we use start date / duration in params.

@louisquentinjoucla
Copy link
Contributor

Yea so here is a bad news:
Some modules does not put start date, duration, end date...

So back to the start it is ! Lets try to find another way 😅 . But we should definitely make a list of useful callback we need to open an issue and PR on ansible repo.

@mhansen
Copy link
Owner Author

mhansen commented Jun 22, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants