Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interpolation in events B name #17

Merged
merged 1 commit into from
Jun 26, 2022
Merged

Fix interpolation in events B name #17

merged 1 commit into from
Jun 26, 2022

Conversation

louisquentinjoucla
Copy link
Contributor

@louisquentinjoucla louisquentinjoucla commented Jun 13, 2022 •
edited

Fix #16

Thanks!

@louisquentinjoucla louisquentinjoucla changed the title #16 interpolation Fix interpolation in events B name Jun 13, 2022
mhansen
mhansen reviewed Jun 16, 2022
View reviewed changes
tests/integration/tests/include_task.py Outdated
JSONTYPE = Union[None, int, str, bool, List[Any], Dict[str, Any]]
from event import HostEvent

# @pytest.mark.ansible_playbook('include_task/playbook_no_templating.yml')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why tests commented out? (maybe I'll review this one after we can merge the other PR and have a clean rebase of this on top)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was uncommented in the last commit 😅 , should have squashed both commits 😄

But yeah, let me first fix #15 and once this will be merged, I will rebase this PR

@louisquentinjoucla louisquentinjoucla force-pushed the dev/ljoucla/11_interpolation branch 3 times, most recently from 6bc3596 to 20961ee Compare June 19, 2022 06:15
@louisquentinjoucla louisquentinjoucla marked this pull request as ready for review June 19, 2022 06:16
@louisquentinjoucla
Copy link
Contributor Author

Hey 👋 ,

This is the little hack for interpolation issue, had a little fight with git, but it's rebased and squashed !

@mhansen
Copy link
Owner

mhansen commented Jun 25, 2022

Happy to merge this, just have to resolve merge conflicts first

@louisquentinjoucla
Copy link
Contributor Author

louisquentinjoucla commented Jun 25, 2022 •
edited

Done!

@mhansen
Copy link
Owner

mhansen commented Jun 25, 2022

Can you rebase on top of main? I'm havingg trouble rebase-and-merging, and this repo has PR merge commits turned off. Sorry to be a pain

@louisquentinjoucla
Copy link
Contributor Author

louisquentinjoucla commented Jun 25, 2022 •
edited

Lol no problem!

nope wait, forgot to pull on my fork

@louisquentinjoucla
fix(event name): Handle interpolation for task names
b2cb66a 
fix(event name):more tests

fix(interpolation): Check name of B and E events

revert(trace): Clean before squash

fix(tests): Clean before squash
@louisquentinjoucla
Copy link
Contributor Author

here should be good

@mhansen mhansen merged commit 2f286a0 into mhansen:main Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhansen mhansen mhansen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle task name interpolation
2 participants
@louisquentinjoucla @mhansen