Remove video clip after frame extraction #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the download_video_clip_and_extract_frames function in mqtt_client.py to delete the downloaded video clip after the frames have been extracted. This change helps to manage disk space by removing unnecessary files after they have been processed.
This commit wraps the video clip saving and frame extraction process in a try-except block to handle potential OSError exceptions. If an OSError occurs, an error message is logged and an empty list of frames is returned. This prevents the program from crashing when there's an issue with saving the video clip.
mhaowork
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Thanks for catching this. I am not a Python expert. I saw that a Python idiom way is to use with context to enclose the tempfile operations and then the temp files should get cleaned up automatically.
https://docs.python.org/3/library/tempfile.html#tempfile.TemporaryDirectory
... on system reboot :) |
I thought it is once exiting the "On completion of the context or destruction of the temporary directory object, the newly created temporary directory and all its contents are removed from the filesystem." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the download_video_clip_and_extract_frames function in mqtt_client.py to delete the downloaded video clip after the frames have been extracted. This change helps to manage disk space by removing unnecessary files after they have been processed.