Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding drag and drop integration test helpers #76

Merged
merged 2 commits into from
Mar 29, 2017

Conversation

robustdj
Copy link
Contributor

@robustdj robustdj commented Nov 28, 2016

This PR intended adds a drag test helper for integration tests.

For example:

drag('.drag-handle-css-selector', {
  beforeDrop: function() {
    // here would be an opportunity to assert things before dropping
  },
  drop: '.drop-target-selector'
});

@dgavey
Copy link
Collaborator

dgavey commented Nov 30, 2016

This will be useful, thanks for this. I'll need to test this a bit more and make sure we have some test examples and an updated readme before I can release it though.

@robustdj
Copy link
Contributor Author

Sounds good, I can help provide that. I just wanted to make sure that the approach was okay, before I dug in and worked on it some more. I'll push a few commits later this week

@robustdj
Copy link
Contributor Author

@dgavey What can I do to help push this PR through? Add a test that uses the helper and update the README?

@dgavey
Copy link
Collaborator

dgavey commented Jan 11, 2017

Sorry, kind of dropped the ball on this. We will need some tests that use the helpers to confirm they are working, and some info in the readme under a new tests section would be fantastic.

@robustdj
Copy link
Contributor Author

@dgavey I just pushed a commit that has tests for the test helpers and documentation in the README. Please take a look when you get a chance and let me know if anything else needs to be added/fixed.

@robustdj robustdj changed the title Adding drag and drop integration test helpers [WIP] Adding drag and drop integration test helpers Feb 24, 2017
@dgavey
Copy link
Collaborator

dgavey commented Mar 29, 2017

This is great, thanks so much for this!

@dgavey dgavey merged commit b4b6578 into mharris717:master Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants