feat(): remove "No changes necessary with {formatter}" print #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 Thanks for fixing this. I save regularly and find the status message that this PR removes very distracting. I hope this gets merged or otherwise addressed. Happy to help make this happen. |
ajoslin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @mhartington 馃憢
Love the plugin but this one log when there are no changes seems to me to just get in the way. As a user I don't want the plugin to print for me unless it's useful information. And telling me essentially, 'you're already formatted' is not useful IMO.
This just removes that line.
The other option would be to put this print behind the
loggingoption, but I couldn't quite figure out how to do that (not too familiar with neovim plugins)