Skip to content
This repository has been archived by the owner on Oct 24, 2021. It is now read-only.

feat(): Use location list instead of quickfix list #51

Closed
wants to merge 1 commit into from

Conversation

ahstro
Copy link
Contributor

@ahstro ahstro commented May 22, 2017

Create an option - g:nvim_typescript#use_location_list - that, when set to 1, puts the errors from TSGetErr in the location list instead of the quickfix list.

I'm not all that comfortable writing Vim plugins, but this worked locally. Not sure if the check should be somewhere else in the code as well?

Edit: Also, not sure if 0 should be used for the window number? It's what is used in Neomake and, like I said, it worked for me, but there might be a better option?

@mhartington
Copy link
Owner

Hmm, why dont we just make it use location list instead by default.
Im thinking, getErr only returns the errors for the current file. So a location list will be fine here.

When I build the neomake integration, I can add an option to open/close the loclist.
Still need to figure out how to do the neomake integration.

Would you mind updating your PR to just use loclist instead?

@ahstro
Copy link
Contributor Author

ahstro commented May 22, 2017

Sure, if that's the better option in your opinion. I don't really understand the difference between the two.

When I build the neomake integration

❤️ 🥇 💯

@ahstro ahstro changed the title feat(): Add option to use location list instead of quickfix list feat(): Use location list instead of quickfix list May 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants