Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom docs_dir and custom domain #107

Open
frealmyr opened this issue Jul 8, 2021 · 1 comment
Open

custom docs_dir and custom domain #107

frealmyr opened this issue Jul 8, 2021 · 1 comment

Comments

@frealmyr
Copy link
Contributor

frealmyr commented Jul 8, 2021

The CUSTOM_DOMAIN environment variable does not work when also using a custom docs_dir in mkdocs.yml.

When specifying a custom docs_dir such as

docs_dir: articles/

Build will fail with the following error:

/action.sh: line 24: /github/workspace/docs/CNAME: No such file or directory

The correct folder to target for CNAME file creation should in this instance should be articles/.

A neat way to solve this would be to lookup the key in mkdocs.yml (using yq maybe?), and the easiest would be to add another environment variable.

@mhausenblas
Copy link
Owner

Wanna PR it? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants