Add V3 custom fields endpoints

[timchaston]

Hi,

Wrote up the endpoints for contact custom fields. I've also done some work on endpoints for custom field values - which is primarily what I'm needing to get working - but I realised that it would make sense to submit this first as groundwork.

Let me know what adjustments are needed.

Thanks,
Tim

[timchaston]

I see the CI is failing, seemingly because the environment variables aren't set, due to Travis CI security restrictions. Are you able to tell me if there's anything I need to do from my side to address that?

[mhenrixon]

Only one small remark where you think you are testing the update but in fact the field was already created with those values so the update isn't really testing anything.

Unfortunately, I don't know of a way of sharing the tokens. The one reason I don't want to have my own test account available to the public is to avoid having to clean up data from failed test runs so I suggest on your travis account that you add the missing environment variables for

• ACTIVE_CAMPAIGN_URL
• ACTIVE_CAMPAIGN_TOKEN

At least if you plan on creating another PR it would make sense to do that to make it easier to review if the code is tested properly and tests are passing.

Normally (for other services), it wouldn't be a problem but I've had quite a few issues with testing ActiveCampaign.

[mhenrixon]

Actually since I believe I filter the tokens it might be enough to set something dummy unless the environment variable is configured

I’ll have a look at that

[mhenrixon]

It should build properly if you merge my master into your branch now! 👍

[mhenrixon]

Ok, I try to explain myself a little better. Basically, for any single test. All HTTP interactions are recorded into a single file. That is why the name of it "returns a field_hash is so darn important.

A couple of things that I would like to improve (to avoid having to be so picky):

1. Reusable VCR cassettes (meaning I can select the cassettes at will as requests are made. Like when the user or contact is created I pick a cassette for that specific request to avoid this duplication in the test setup. The problem is that I constantly discover dependencies between contacts, pipelines, etc having. to be recorded in a specific order that I haven't figured out the best way to do this yet. If you have any suggestions I'm all ears. This way we could name the cassettes based on resources instead of tests which would help avoid the confusion like between you and me right now. Another possibility would be to better match the cassettes on interaction and let VCR pick one for another test. Don't know if the last one is an option though.
2. I'd like to then remove the strings in the tests so that the entire test line becomes it { is_expected.to eq(expected_result) } because I find the maintenance of test strings to be cumbersome and error prone but until I fix number 1 this leads to really confusing cassette names so for the sake of clarity I'd like to be as specific as possible about what type of hash is expected in the test name.

[codeclimate]

Code Climate has analyzed commit 73b59bf and detected 0 issues on this pull request.

View more on Code Climate.

[timchaston]

I've updated the PR in line with your feedback. CI is looking good!

[mhenrixon]

Nice work and many thanks for your contribution.